Typeguard 4.3.0 #97
Typeguard 4.3.0 #97
Conversation
…4.3.0 # Conflicts: # setup.py
|
Hang on a minute, this is only used in tests? We can move this from install_requires to being a dependency of only the test environment! And - it looks like |
|
Probably easier to describe that by making the change - what do you think? #98 (And if it's a test requirement, we don't have to over think the permissiveness of the lower bound!) |
I think your solution is good, as this fully resolves the conflict also for the future (as long as one is not doing testing). |
|
We are also eager to see either change made, please. (In the meantime we have been using |
|
@ChristianWirthContinental @tmct the locked version of typeguard was intentional (but poorly documented in the code). Newer versions of typeguard aren't compatible with jaxtyping. See: It's worth noting that typeguard versioning has caused previous issues. As a workaround, we can require the specific locked version of typeguard in our testing code (where we need the specific version for jaxtyped tests) but we don't have to lock down typeguard for the main package dependencies (where jaxtyping is strictly used for annotations only). |
|
Thank you! n.b. if you ever upgrade your min version of jaxtyping beyond I think 0.2.22, as things stand I think we'd hit the same problem again through transitive dependencies being tightened... So hopefully jaxtyping can be made compatible before then! |
|
@gpleiss Thank you very much! If you don't mind releasing this, i would try to get the new version into botorch to resolve the version conflicts in the dependency chain. |
|
Done |
Fixes #84 by updating typeguard to 4.X
This is important because the typeguard requirement is in conflict with ydata-profiling: https://github.com/ydataai/ydata-profiling/blob/cc7b9b36364fdcb6db6a23db5d83ad3c6e2e3c8f/requirements.txt#L23 - a commonly used EDA package.
This, in turn, prevents updates to pandas and numpy.
All unittests passed